----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25927/#review54248 -----------------------------------------------------------
Ship it! recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerStateModel.java <https://reviews.apache.org/r/25927/#comment94260> It would be nice to rename this to ConsumerTransitionHandler to make it consistent with the name change for the interface. - Kanak Biscuitwala On Sept. 22, 2014, 10:03 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25927/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2014, 10:03 p.m.) > > > Review request for helix and Shi Lu. > > > Bugs: HELIX-489 > > > Repository: helix-git > > > Description > ------- > > [HELIX-489] Convert rabbitmq to use new API > > > Diffs > ----- > > > recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/Consumer.java > de56171 > > recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerStateModel.java > b41ccf7 > > recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerStateTransitionHandlerFactory.java > a0d11f8 > > recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerThread.java > ddd466c > > Diff: https://reviews.apache.org/r/25927/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
