> On Oct. 1, 2014, 4:19 a.m., Kanak Biscuitwala wrote:
> > helix-core/src/main/java/org/apache/helix/task/TaskDriver.java, line 383
> > <https://reviews.apache.org/r/26212/diff/1/?file=709970#file709970line383>
> >
> > Why this change?
For TaskDriver#setTaskTargetState:
private void setTaskTargetState(String jobResource, TargetState state) {
setSingleTaskTargetState(jobResource, state);
// For recurring schedules, child workflows must also be handled
HelixDataAccessor accessor = _manager.getHelixDataAccessor();
List<String> resources =
accessor.getChildNames(accessor.keyBuilder().resourceConfigs());
for (String resource : resources) {
String prefix = resource + "_" + TaskConstants.SCHEDULED;
if (resource.startsWith(prefix)) {
setSingleTaskTargetState(resource, state);
}
}
}
If I understand correctly, prefix should be jobResource + "_" +
TaskConstants.SCHEDULED instead of resource + "_" + TaskConstants.SCHEDULED,
otherwise resource.startsWith(prefix) doesn't seem to make sense?
- Zhen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26212/#review55051
-----------------------------------------------------------
On Oct. 1, 2014, 1 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26212/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2014, 1 a.m.)
>
>
> Review request for helix, Kanak Biscuitwala and Shi Lu.
>
>
> Bugs: 519
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> [HELIX-519] Add integration tests to ensure that "kill-switch" for Helix
> tasks work as expected
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/task/TaskDriver.java 31d785b
>
> helix-core/src/test/java/org/apache/helix/integration/task/TestTaskRebalancerStopResume.java
> 4e0d92a
> helix-core/src/test/java/org/apache/helix/integration/task/TestUtil.java
> f599920
>
> Diff: https://reviews.apache.org/r/26212/diff/
>
>
> Testing
> -------
>
> mvn test
>
>
> Thanks,
>
> Zhen Zhang
>
>
