[
https://issues.apache.org/jira/browse/HELIX-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14207673#comment-14207673
]
ASF GitHub Bot commented on HELIX-537:
--------------------------------------
Github user kanakb commented on the pull request:
https://github.com/apache/helix/pull/8#issuecomment-62669496
```[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR :
[INFO] -------------------------------------------------------------
[ERROR]
/Users/kanak/Developer/incubator-helix/helix-core/src/main/java/org/apache/helix/task/TaskStateModel.java:[70,2]
missing return statement
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE```
`TaskStateModel#shutdown` has return type `boolean`, but returns nothing.
> org.apache.helix.task.TaskStateModel should have a shutdown method.
> -------------------------------------------------------------------
>
> Key: HELIX-537
> URL: https://issues.apache.org/jira/browse/HELIX-537
> Project: Apache Helix
> Issue Type: Bug
> Components: helix-core
> Affects Versions: 0.6.3
> Reporter: Antony T Curtis
> Priority: Blocker
>
> There should be a shutdown method to terminate the Timer and Executor which
> the org.apache.helix.task.TaskStateModel class creates.
> ie.
> {noformat}
> public boolean shutdown(long timeout, TimeUnit unit)
> throws InterruptedException
> {
> reset();
> _taskExecutor.shutdown();
> _timer.cancel();
> return _taskExecutor.awaitTermination(timeout, unit);
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
