----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28211/#review62125 -----------------------------------------------------------
Ship it! Ship it, but this is definitely going to cause some crankiness for people who want to upgrade. Please also make the corresponding changes to master. helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelFactory.java <https://reviews.apache.org/r/28211/#comment104074> "resourceName" and "partitionKey" seems like inconsistent naming - Kanak Biscuitwala On Nov. 18, 2014, 7:05 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28211/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2014, 7:05 p.m.) > > > Review request for helix and Kishore Gopalakrishna. > > > Bugs: HELIX-552 > > > Repository: helix-git > > > Description > ------- > > [HELIX-552] StateModelFactory#_stateModelMap should use both resourceName and > partitionKey to map a state model > > This is a backward incompatible change, but the change is trivial and is > detected at compile time: > Instead of implementing: > StateModelFactory#createAndAddStateModel(String partitionKey) > > We now require implementing > StateModelFactory#createAndAddStateModel(String resourceName, String > partitionKey) > > > Diffs > ----- > > > helix-agent/src/main/java/org/apache/helix/agent/AgentStateModelFactory.java > a0e00a3 > helix-core/src/main/java/org/apache/helix/PropertyKey.java a394b50 > helix-core/src/main/java/org/apache/helix/examples/BootstrapHandler.java > f1b37fc > helix-core/src/main/java/org/apache/helix/examples/DummyParticipant.java > 52a3696 > > helix-core/src/main/java/org/apache/helix/examples/LeaderStandbyStateModelFactory.java > 43ac5de > > helix-core/src/main/java/org/apache/helix/examples/MasterSlaveStateModelFactory.java > affbea8 > > helix-core/src/main/java/org/apache/helix/examples/OnlineOfflineStateModelFactory.java > daf03a9 > > helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java > 8da7ec9 > > helix-core/src/main/java/org/apache/helix/participant/DistClusterControllerStateModelFactory.java > a367c81 > > helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyStateModelFactory.java > 51c91cc > > helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java > 31fcecf > > helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModel.java > 8b6a02c > > helix-core/src/main/java/org/apache/helix/participant/statemachine/ScheduledTaskStateModelFactory.java > a205910 > > helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelFactory.java > bd1a668 > helix-core/src/main/java/org/apache/helix/task/TaskStateModelFactory.java > 51e8c95 > helix-core/src/test/java/org/apache/helix/TestHelixTaskExecutor.java > 4aa16eb > helix-core/src/test/java/org/apache/helix/TestHelixTaskHandler.java 3c7f2af > > helix-core/src/test/java/org/apache/helix/integration/TestCorrectnessOnConnectivityLoss.java > 3b44f2c > > helix-core/src/test/java/org/apache/helix/integration/TestEntropyFreeNodeBounce.java > 8a3d727 > > helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle2.java > 7d66780 > > helix-core/src/test/java/org/apache/helix/integration/TestPartitionLevelTransitionConstraint.java > 3571a7b > > helix-core/src/test/java/org/apache/helix/integration/TestPreferenceListAsQueue.java > 456baca > > helix-core/src/test/java/org/apache/helix/integration/TestResourceWithSamePartitionKey.java > e69de29 > > helix-core/src/test/java/org/apache/helix/integration/TestStateTransitionTimeout.java > a297752 > helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java > cc6c0b5 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestStateModelLeak.java > 2aff5b6 > > helix-core/src/test/java/org/apache/helix/mock/participant/DummyProcess.java > 2111a65 > > helix-core/src/test/java/org/apache/helix/mock/participant/MockBootstrapModelFactory.java > 177e7c4 > > helix-core/src/test/java/org/apache/helix/mock/participant/MockMSModelFactory.java > 9325934 > > helix-core/src/test/java/org/apache/helix/mock/participant/MockSchemataModelFactory.java > 525e764 > > helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModelFactory.java > dae58b3 > > recipes/distributed-lock-manager/src/main/java/org/apache/helix/lockmanager/LockFactory.java > cede270 > > recipes/rabbitmq-consumer-group/src/main/java/org/apache/helix/recipes/rabbitmq/ConsumerStateModelFactory.java > c59e9c4 > > recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/FileStoreStateModelFactory.java > 4df8e3d > > recipes/task-execution/src/main/java/org/apache/helix/taskexecution/TaskStateModelFactory.java > 0864ced > > Diff: https://reviews.apache.org/r/28211/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
