----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28584/#review63482 -----------------------------------------------------------
Ship it! Ship It! - Shi Lu On Dec. 2, 2014, 1:06 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28584/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2014, 1:06 a.m.) > > > Review request for helix and Shi Lu. > > > Bugs: HELIX-546 > > > Repository: helix-git > > > Description > ------- > > Add REST API for Helix job queue management > - Add JobQueuesResource, JobQueueResource, and JobResource for > start/stop/resume/list/flush job-queues, enqueue/get a job > - Add test case for start/stop/resume/list/flush job-queue, enqueue/get a job > - Refactor some util methods for getting attributes from helix web-admin > request/context/parameters > > > Diffs > ----- > > > helix-admin-webapp/src/main/java/org/apache/helix/webapp/RestAdminApplication.java > 7e7a3b9 > > helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ClusterRepresentationUtil.java > f227801 > > helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/JobQueueResource.java > e69de29 > > helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/JobQueuesResource.java > e69de29 > > helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/JobResource.java > e69de29 > > helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/JsonParameters.java > 19ac71a > > helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ResourceUtil.java > e69de29 > helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestBase.java > 5b4411b > > helix-admin-webapp/src/test/java/org/apache/helix/webapp/AdminTestHelper.java > 9f6946d > helix-admin-webapp/src/test/java/resources/TestJobQueuesResource.java > e69de29 > helix-admin-webapp/src/test/java/resources/TestJsonParameters.java e69de29 > helix-core/src/main/java/org/apache/helix/task/TaskDriver.java 0bd060a > helix-core/src/main/java/org/apache/helix/task/Workflow.java 1c0ef40 > > Diff: https://reviews.apache.org/r/28584/diff/ > > > Testing > ------- > > mvn test > > > Thanks, > > Zhen Zhang > >
