-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31836/#review76077
-----------------------------------------------------------

Ship it!



helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
<https://reviews.apache.org/r/31836/#comment123472>

    whitespace



helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java
<https://reviews.apache.org/r/31836/#comment123474>

    indentation



helix-core/src/main/java/org/apache/helix/util/GZipCompressionUtil.java
<https://reviews.apache.org/r/31836/#comment123473>

    License should come before imports.



helix-core/src/main/java/org/apache/helix/util/GZipCompressionUtil.java
<https://reviews.apache.org/r/31836/#comment123475>

    whitespace



helix-core/src/test/java/org/apache/helix/integration/TestEnableCompression.java
<https://reviews.apache.org/r/31836/#comment123476>

    whitespace



helix-core/src/test/java/org/apache/helix/integration/TestEnableCompression.java
<https://reviews.apache.org/r/31836/#comment123477>

    whitespace


- Kanak Biscuitwala


On March 11, 2015, 8:49 a.m., Kishore Gopalakrishna wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31836/
> -----------------------------------------------------------
> 
> (Updated March 11, 2015, 8:49 a.m.)
> 
> 
> Review request for helix.
> 
> 
> Repository: helix-git
> 
> 
> Description
> -------
> 
> commit 1ef44c2e9a132df3513a51e3a8dac658236a2263
> Author: Kishore Gopalakrishna <g.kish...@gmail.com>
> Date:   Sun Mar 8 16:40:29 2015 -0700
> 
>     [HELIX-573] Add support to automatically compress/uncompress data in 
> Zookeeper
> 
> :100644 100644 4419fdd... 1f34529... M  
> helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordSerializer.java
> :100644 100644 2d7cb3c... 26d7e2b... M  
> helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java
> :000000 100644 0000000... 90c1e8e... A  
> helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSerializer.java
> :100644 100644 e4b0b25... 95064f8... M  
> helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordStreamingSerializer.java
> :100755 100755 e869f25... 99ef81c... M  hpost-review.sh
> 
> 
> Diffs
> -----
> 
>   
> helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
>  903840c 
>   
> helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordSerializer.java 
> 4419fdd 
>   
> helix-core/src/main/java/org/apache/helix/manager/zk/ZNRecordStreamingSerializer.java
>  2d7cb3c 
>   helix-core/src/main/java/org/apache/helix/util/GZipCompressionUtil.java 
> PRE-CREATION 
>   
> helix-core/src/test/java/org/apache/helix/integration/TestEnableCompression.java
>  PRE-CREATION 
>   
> helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSerializer.java
>  PRE-CREATION 
>   
> helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordStreamingSerializer.java
>  e4b0b25 
> 
> Diff: https://reviews.apache.org/r/31836/diff/
> 
> 
> Testing
> -------
> 
> Added basic test for compress/uncompress
> 
> 
> Thanks,
> 
> Kishore Gopalakrishna
> 
>

Reply via email to