> On March 12, 2015, 5:48 a.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java, > > line 190 > > <https://reviews.apache.org/r/31970/diff/1/?file=891921#file891921line190> > > > > Add a comment why we are doing this
will do - Zhen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31970/#review76210 ----------------------------------------------------------- On March 12, 2015, 5:45 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/31970/ > ----------------------------------------------------------- > > (Updated March 12, 2015, 5:45 a.m.) > > > Review request for helix, Kanak Biscuitwala and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-574] fix bucketize resource bug in current state carryover > > One logic change is previous we don't allow drop a disabled resource. Now we > change to drop a resource regardless it's disabled or not. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java > 0f3fbc4 > > helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/ConstraintBasedAssignment.java > bab357b > > helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManagerHelper.java > 1bee2fe > > helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixDataAccessor.java > 8c9fc8d > > helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java > 2b5e2bc > > Diff: https://reviews.apache.org/r/31970/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
