----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32068/#review76480 -----------------------------------------------------------
Ship it! Nice. I initially thought changing abstract to non abstract will break binary compatibility. But Kanak pointed me to this http://docs.oracle.com/javase/specs/jls/se7/html/jls-13.html where it says "Changing a method that is declared abstract to no longer be declared abstract does not break compatibility with pre-existing binaries." - Kishore Gopalakrishna On March 14, 2015, 6:07 a.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/32068/ > ----------------------------------------------------------- > > (Updated March 14, 2015, 6:07 a.m.) > > > Review request for helix and Kishore Gopalakrishna. > > > Repository: helix-git > > > Description > ------- > > [HELIX-567] Make StateModelFactory change backward compatible > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelFactory.java > b775016 > > Diff: https://reviews.apache.org/r/32068/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
