GitHub user jicongrui opened a pull request:
https://github.com/apache/helix/pull/26
[HELIX-592] addCluster should respect overwriteExisitng when adding stat...
...eModelDefinations
There are some tests expecting exceptions when creating an existing cluster
and I change the result.
So the question is that the business logic of creating a exisiting cluster.
If we allow that and overwrite is false, should we throw exceptions or do
nothing?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jicongrui/helix helix-0.6.x
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/26.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #26
----
commit 69cd1f27065710f6de157b82742673ab8baf5d11
Author: Congrui Ji <[email protected]>
Date: 2015-04-29T23:13:11Z
[HELIX-592] addCluster should respect overwriteExisitng when adding
stateModelDefinations
There are some tests expecting exceptions when creating an existing cluster
and I change the result.
So the question is that the business logic of creating a exisiting cluster.
If we allow that and overwrite is false, should we throw exceptions or do
nothing?
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
