----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34345/#review84576 -----------------------------------------------------------
Ship it! LGTM. Thanks for the fix! You can probably send a pull request on github instead, so the fix can be easily merged under your name. - Zhen Zhang On May 18, 2015, 7:54 a.m., Hang Qi wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34345/ > ----------------------------------------------------------- > > (Updated May 18, 2015, 7:54 a.m.) > > > Review request for helix. > > > Bugs: HELIX-596 > > > Repository: helix-git > > > Description > ------- > > commit 9ddbefcacff6b8e229e6413299d53d89f1cbcd43 > Author: Hang Qi <[email protected]> > Date: Sun May 17 23:06:20 2015 -0700 > > [HELIX-596] fix throttled messages still take constraints' quota > > :100644 100644 39bb228... 635ac17... M > helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java > :100644 100644 29228e4... 40823a8... M > helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java > :100644 100644 32106e1... edab4c4... M > helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java > 39bb228 > > helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java > 29228e4 > helix-core/src/test/java/org/apache/helix/testutil/HelixTestUtil.java > 32106e1 > > Diff: https://reviews.apache.org/r/34345/diff/ > > > Testing > ------- > > Add One UT TestMessageThrottleStage#testMsgThrottleConstraintsQuota > > This UT fails prior to the patch, and passed after the fix. > > > Thanks, > > Hang Qi > >
