Github user kanakb commented on a diff in the pull request:
https://github.com/apache/helix/pull/30#discussion_r32904781
--- Diff:
helix-core/src/main/java/org/apache/helix/task/TaskRebalancer.java ---
@@ -134,14 +134,22 @@ public ResourceAssignment
computeBestPossiblePartitionState(ClusterDataCache clu
workflowCtx.setStartTime(System.currentTimeMillis());
}
- // Check parent dependencies
- for (String parent :
workflowCfg.getJobDag().getDirectParents(resourceName)) {
- if (workflowCtx.getJobState(parent) == null
- || !workflowCtx.getJobState(parent).equals(TaskState.COMPLETED))
{
- return emptyAssignment(resourceName, currStateOutput);
+ // check ancestor job status
+ int unStartCount = 0;
--- End diff --
Please rename to `notStartedCount` and `incompleteCount`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
