Github user lei-xia commented on the pull request:
https://github.com/apache/helix/pull/38#issuecomment-154924074
It is little bit tricky to add unit test to verify there is no leaking,
also it takes some time to generate and detect leaking, which makes the unit
tests takes even longer time (it already takes quite long time to run all unit
tests now).
Having said that, although we do not have unit test on this, we have
already verified this fix on our testing environments, with Helix runs for two
days, starting and finishing around ~10000 jobs. We did not see significant
amount of threads created as we saw before, and also the thread numbers keeps
pretty stable over the time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
