Github user lei-xia commented on a diff in the pull request:

    https://github.com/apache/helix/pull/52#discussion_r81051293
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/controller/rebalancer/strategy/AutoRebalanceStrategy.java
 ---
    @@ -129,9 +129,8 @@ public ZNRecord computePartitionAssignment(final 
List<String> allNodes, final Li
           logger.info("orphan = " + _orphaned);
         }
     
    -    moveNonPreferredReplicasToPreferred();
    -
         assignOrphans();
    +    moveNonPreferredReplicasToPreferred();
    --- End diff --
    
    Because assignOrphans() will also assign some new partitions to 
non-preferred nodes.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to