[ 
https://issues.apache.org/jira/browse/HELIX-636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15603789#comment-15603789
 ] 

ASF GitHub Bot commented on HELIX-636:
--------------------------------------

Github user lei-xia commented on a diff in the pull request:

    https://github.com/apache/helix/pull/55#discussion_r84814968
  
    --- Diff: helix-core/src/main/java/org/apache/helix/task/TaskDriver.java ---
    @@ -421,8 +428,7 @@ private void deleteJobFromScheduledQueue(final String 
queueName, final String jo
     
         // Delete the job from property store
         String jobPropertyPath =
    -        Joiner.on("/")
    -            .join(TaskConstants.REBALANCER_CONTEXT_ROOT, 
namespacedJobName);
    +        Joiner.on("/").join(TaskConstants.REBALANCER_CONTEXT_ROOT, 
namespacedJobName);
         _propertyStore.remove(jobPropertyPath, AccessOption.PERSISTENT);
    --- End diff --
    
    let us use removeJobContext() in the taskUtil?


> JobQueue capacity is full due to job not cleaned up
> ---------------------------------------------------
>
>                 Key: HELIX-636
>                 URL: https://issues.apache.org/jira/browse/HELIX-636
>             Project: Apache Helix
>          Issue Type: Bug
>          Components: helix-core
>    Affects Versions: 0.6.4
>            Reporter: Junkai Xue
>            Assignee: Junkai Xue
>             Fix For: 0.6.x
>
>
> Since JobQueue never cleans up the jobs in the final stage (FAILED, 
> COMPLETED, ABORTED), JobQueue will reach the capacity limit when jobs keep 
> adding in.
> Fix: Current fix will be adding an API in TaskDriver to clean up the final 
> statge.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to