Github user lei-xia commented on a diff in the pull request:
https://github.com/apache/helix/pull/55#discussion_r85445965
--- Diff:
helix-core/src/main/java/org/apache/helix/task/WorkflowRebalancer.java ---
@@ -496,11 +496,10 @@ private void cleanupJob(final String job, String
workflow) {
// Delete job context
// For recurring workflow, it's OK if the node doesn't exist.
- String propStoreKey = TaskUtil.getWorkflowContextKey(job);
- if (!_manager.getHelixPropertyStore().remove(propStoreKey,
AccessOption.PERSISTENT)) {
+ if (!TaskUtil.removeJobContext(_manager, job)) {
LOG.warn(String.format(
"Error occurred while trying to clean up job %s. Failed to
remove node %s from Helix.",
- job, propStoreKey));
+ job, TaskUtil.getWorkflowContextKey(job)));
--- End diff --
do not need TaskUtil.getWorkflowContextKey(job). just log something like:
"Error ... when clean up job's workflow context..."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
