Github user pnarayanan commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95283527
--- Diff: helix-core/src/main/java/org/apache/helix/HelixAdmin.java ---
@@ -51,6 +51,16 @@
InstanceConfig getInstanceConfig(String clusterName, String
instanceName);
/**
+ * Set the instance config of an existing instance under the given
cluster.
+ * @param clusterName the name of the cluster to which this instance
belongs.
+ * @param instanceName the name of this instance.
+ * @param instanceConfig the new {@link InstanceConfig} that will
replace the current one
+ * associated with this instance.
+ * @return true if the operation was successful; false otherwise.
+ */
+ boolean setInstanceConfig(String clusterName, String instanceName,
InstanceConfig instanceConfig);
--- End diff --
Could do that, but doesn't `setInstanceConfig(clusterName, instanceConfig)`
feel a bit odd as an API?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
