[
https://issues.apache.org/jira/browse/HELIX-651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15813456#comment-15813456
]
ASF GitHub Bot commented on HELIX-651:
--------------------------------------
Github user pnarayanan commented on a diff in the pull request:
https://github.com/apache/helix/pull/65#discussion_r95283527
--- Diff: helix-core/src/main/java/org/apache/helix/HelixAdmin.java ---
@@ -51,6 +51,16 @@
InstanceConfig getInstanceConfig(String clusterName, String
instanceName);
/**
+ * Set the instance config of an existing instance under the given
cluster.
+ * @param clusterName the name of the cluster to which this instance
belongs.
+ * @param instanceName the name of this instance.
+ * @param instanceConfig the new {@link InstanceConfig} that will
replace the current one
+ * associated with this instance.
+ * @return true if the operation was successful; false otherwise.
+ */
+ boolean setInstanceConfig(String clusterName, String instanceName,
InstanceConfig instanceConfig);
--- End diff --
Could do that, but doesn't `setInstanceConfig(clusterName, instanceConfig)`
feel a bit odd as an API?
> Add a method in HelixAdmin to set the InstanceConfig of an existing instance
> ----------------------------------------------------------------------------
>
> Key: HELIX-651
> URL: https://issues.apache.org/jira/browse/HELIX-651
> Project: Apache Helix
> Issue Type: Improvement
> Components: helix-core
> Affects Versions: 0.6.x, master
> Reporter: Priyesh
> Labels: newbie
> Fix For: 0.6.x, master
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> There is seemingly no way to set the InstanceConfig of an instance via the
> HelixAdmin, after the instance is added to the cluster. It would be useful to
> have a setInstanceConfig() similar to getInstanceConfig().
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
