Github user dasahcc commented on a diff in the pull request:
https://github.com/apache/helix/pull/91#discussion_r115886683
--- Diff:
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
---
@@ -210,6 +213,18 @@ private void
updateStateTransitionMessageThreadPool(Message message, HelixManage
return;
}
+ if (!_batchMessageThreadpoolChecked) {
--- End diff --
This is not a proper solution for the problem. We shall keep the backward
compatible. HelixTaskExecutor has a default constructor now. In this case, if
the HelixTaskExecutor instantiated by default constructor does not have any
information for configurable threadpool. That's why there is also a logic to
make the threadpool configurable in a separate method (not only for batch
message thread pool). Otherwise, the user defined the information will be
ignored. It is not good just remove the public constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
