GitHub user jiajunwang opened a pull request:
https://github.com/apache/helix/pull/142
[HELIX-675] Refactor controller start/cleanup logic to ensure monitorâ¦
⦠register/reset is handled in any event orders.
Due to different possible event process order, controller init event might
be processed later or earlier than expected.
This cause inconsistency when even handler thread process and record
information in the cluster monitor.
This change ensures cluster monitor is off when the leadership changes to
other node. So no extra metric data will be generated.
Also upgrade related test cases to verify MBean counts.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiajunwang/helix helix-675
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #142
----
commit f5017c35d2971bb8a5de7b8defca77c0ffdd13bb
Author: jiajunwang <ericwang1985@...>
Date: 2018-03-09T00:51:37Z
[HELIX-675] Refactor controller start/cleanup logic to ensure monitor
register/reset is handled in any event orders.
Due to different possible event process order, controller init event might
be processed later or earlier than expected.
This cause inconsistency when even handler thread process and record
information in the cluster monitor.
This change ensures cluster monitor is off when the leadership changes to
other node. So no extra metric data will be generated.
Also upgrade related test cases to verify MBean counts.
----
---
