Github user mcvsubbu commented on a diff in the pull request:
https://github.com/apache/helix/pull/145#discussion_r174307432
--- Diff:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/constraint/PartitionWeightAwareEvennessConstraint.java
---
@@ -0,0 +1,94 @@
+package org.apache.helix.controller.rebalancer.constraint;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import
org.apache.helix.api.rebalancer.constraint.AbstractRebalanceSoftConstraint;
+import
org.apache.helix.api.rebalancer.constraint.dataprovider.CapacityProvider;
+import
org.apache.helix.api.rebalancer.constraint.dataprovider.PartitionQuotaProvider;
+import org.apache.helix.controller.common.ResourcesStateMap;
+import org.apache.helix.controller.rebalancer.util.ResourceUsageCalculator;
+
+import java.util.HashMap;
+import java.util.Map;
+
+public class PartitionWeightAwareEvennessConstraint extends
AbstractRebalanceSoftConstraint {
+ private final int _weight;
+ private final PartitionQuotaProvider _partitionQuotaProvider;
+ private final CapacityProvider _capacityProvider;
+ // Use to track any assignments that are proposed during the rebalance
process.
+ // Note these assignments are not reflected in providers.
+ private final Map<String, Integer> _pendingUsage;
+
+ public PartitionWeightAwareEvennessConstraint(PartitionQuotaProvider
partitionQuotaProvider,
+ CapacityProvider capacityProvider, int weight) {
+ _partitionQuotaProvider = partitionQuotaProvider;
+ _capacityProvider = capacityProvider;
+ _weight = weight;
--- End diff --
Not clear what this weight means. Does this mean the relative importance of
this constraint vs any other? If so, maybe we should consider naming these
correctly. we have partition weights and constraint weights....
Also, _weight is not used in the class? Should it move to the super class?
---
