GitHub user narendly opened a pull request:
https://github.com/apache/helix/pull/231
Refactor AssignableInstanceManager
This RB refactors AssignableInstanceManager's constructor so that the
actual building of AssignableInstances is separated into another public method.
This allows the instantiation of AssignableInstanceManager in TaskDataCache
without having to provide metadata for building AssignableInstances.
ChangeList:
1. Add an empty constructor
2. Put build logic in a separate method
3. A boolean flag was added for buildAssignableInstances() to prevent it
from building AssignableInstance objects from scratch every time this method is
called by TaskDataCache's refresh()
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/narendly/helix 1322928
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/231.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #231
----
commit a4c1edf602b1195ed2f21846924e2d9731115f86
Author: Hunter Lee <narendly@...>
Date: 2018-07-10T01:39:24Z
[HELIX-724] Refactor AssignableInstanceManager
This RB refactors AssignableInstanceManager's constructor so that the
actual building of AssignableInstances is separated into another public method.
This allows the instantiation of AssignableInstanceManager in TaskDataCache
without having to provide metadata for building AssignableInstances.
ChangeList:
1. Add an empty constructor
2. Put build logic in a separate method
3. A boolean flag was added for buildAssignableInstances() to prevent it
from building AssignableInstance objects from scratch every time this method is
called by TaskDataCache's refresh()
----
---
