GitHub user jiajunwang opened a pull request:
https://github.com/apache/helix/pull/253
Sync the local change about RoutingTableProvider and related metrics change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jiajunwang/helix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/253.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #253
----
commit acea2f16bce6c439fdc8d1dfb8ad37650679f822
Author: Jiajun Wang <jjwang@...>
Date: 2018-06-29T22:07:53Z
Refine RoutingTable refresh() logic.
Simplify the construtors.
Refine Log string to a clearer statement.
Fixing a potential bug that empty instanceConfig is recorded in the
RoutingTable.
commit 964b802cfb5ea32bd1ff4f780c0efff97ceb64b3
Author: Jiajun Wang <jjwang@...>
Date: 2018-07-09T22:08:12Z
Fix 2 test bugs that fails mvn test.
TestZkReconnect has a racing issue that the expected flag maybe set
earlier. Change the test script to wait until the flag is configured.
BestPossibleExternalViewVerifier has an issue that when best possible state
is not able to be calculated, the verifier always return false. The expected
behavior is return true if the external view does not exist.
commit 3deeeabaa988bf40c0ba953209dd6b26df984552
Author: Jiajun Wang <jjwang@...>
Date: 2018-07-12T22:20:19Z
Fix the issue that resource MBean may not be cleaned up when the resource
is dropped.
If a resource is not successfully created on any participant, and it is
removed in this situation, the corresponding MBean maybe left over by the
controller.
This fix will ensure all resource MBeans that are no longer related to any
living resource to be removed.
commit 993beb3834f4013de8d6d8221bd71ccdced93632
Author: Jiajun Wang <jjwang@...>
Date: 2018-07-12T17:33:21Z
Adding RoutingTableProvider monitor for tracking refresh actions and
routing table update callbacks.
The monitor contains following metrics.
DataRefreshLatencyGauge
CallbackCounter
EventQueueSizeGauge
DataRefreshCounter
Also add tests for this monitor.
----
---
