GitHub user zhan849 opened a pull request:
https://github.com/apache/helix/pull/270
[HELIX-753] Record top state handoff finished in single cluster data cache
refresh
This PR adds top state handoff reporting when a single pipeline refresh
catches the entire handoff process, which we missed before. Here is the rough
procedure:
- retrieve cached last top state instance for a partition
- retrieve current top state instance for a partition
- if there is no missing top state record of that partition, and top state
instance changed, we record the number
Current top state end time is easy to find from current state in cluster
data cache, for handoff start time, if we cannot find it, we use last pipeline
run's end time for best guess. Detailed reason is explained in code comment.
Added test case to verify such top state handoff, and consolidated common
part in TestTopStateHandoffMetrics for avoiding code replication
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zhan849/helix harry/topstate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/270.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #270
----
commit d501e8fa30596d9cd98078f0d1ce7c1ecf20c595
Author: Harry Zhang <hrzhang@...>
Date: 2018-09-21T21:32:15Z
[HELIX-753] Record top state handoff finished in single cluster data cache
refresh
----
---
