[
https://issues.apache.org/jira/browse/HELIX-756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627683#comment-16627683
]
ASF GitHub Bot commented on HELIX-756:
--------------------------------------
GitHub user narendly opened a pull request:
https://github.com/apache/helix/pull/271
[HELIX-756] TASK: Change LOG mode from info to debug
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/narendly/helix master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/helix/pull/271.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #271
----
commit 5140db0c50439c115d0c7d2637f7ad723f6f147a
Author: Hunter Lee <hulee@...>
Date: 2018-09-25T17:19:31Z
[HELIX-754] TASK: Fix LiveInstanceCurrentState change flag
Previously, existsLiveInstanceOrCurrentStateChange was getting reset in
ClusterDataCache when its getter was called. This was problematic because if
there were multiple jobs or multiple workflows, whoever calls this getter would
get the correct flag value, and the ensuing callers would get a false because
the flag would have been reset. This RB fixes that bug by reseting the flat
right in the beginning of refresh() call in ClusterDataCache, which allows all
callers during that pipeline would get the same, correct value.
Changelist:
1. Change the getter so that it does not reset the flag; instead, reset the
flag in the beginning of refresh()
commit e9f6c98dc58cb7bb842ff1f41063174003277823
Author: Hunter Lee <hulee@...>
Date: 2018-09-25T17:22:36Z
[HELIX-755] TASK: Build quota profile from scratch every rebalance
It has been reported that instances have a full quota despite no tasks
existing in their CURRENTSTATES. The cause of this is not clear, so making
ClusterDataCache trigger a refresh of all AssignableInstances will ensure that
there aren't situations where it looks like there has been a thread leak.
Optimizations will be implemented if necessary. Changelist: 1. Make
AssignableInstanceManager build all AssignableInstances from scratch every
rebalance
commit 4aaa00727fe34b9cdfde2978eeb8a892dcf29add
Author: Hunter Lee <hulee@...>
Date: 2018-09-25T17:25:39Z
[HELIX-756] TASK: Change LOG mode from info to debug
In production, it was observed that some users were running thousands of
tasks, and since AssignableInstance leaves a line of log for each task assigned
or released, the amount of log that was being generated was too much, and it
was too verbose.
Changelist:
1. Change the logging mode from info to debug in AssignableInstance and
AssignableInstanceManager
----
> TASK: Change LOG mode from info to debug
> ----------------------------------------
>
> Key: HELIX-756
> URL: https://issues.apache.org/jira/browse/HELIX-756
> Project: Apache Helix
> Issue Type: Improvement
> Reporter: Hunter L
> Assignee: Hunter L
> Priority: Major
>
> In production, it was observed that some users were running thousands of
> tasks, and since AssignableInstance leaves a line of log for each task
> assigned or released, the amount of log that was being generated was too
> much, and it was too verbose.
> Changelist:
> 1. Change the logging mode from info to debug in AssignableInstance and
> AssignableInstanceManager
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
