[ https://issues.apache.org/jira/browse/HELIX-770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667948#comment-16667948 ]
ASF GitHub Bot commented on HELIX-770: -------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/helix/pull/277 > HELIX: Fix a possible NPE in loadBalance in IntermediateStateCalcStage > ---------------------------------------------------------------------- > > Key: HELIX-770 > URL: https://issues.apache.org/jira/browse/HELIX-770 > Project: Apache Helix > Issue Type: Improvement > Reporter: Hunter L > Assignee: Hunter L > Priority: Major > > In isLoadBalanceDownwardForAllReplicas() in IntermediateStateCalcStage, > statePriorityMap was throwing a NPE because the partition contained a replica > in ERROR state, and the map did not have an entry for it. To amend the issue, > Venice added the ERROR state in the state model with a priority, and Helix > added checks to prevent NPEs. Changelist: 1. Add containsKey checks in > isLoadBalanceDownwardForAllReplicas() 2. Make the Controller correctly log > all partitions with ERROR state replicas 3. Add HelixDefinedStates in > statePriorityList if not already added -- This message was sent by Atlassian JIRA (v7.6.3#76005)