Github user lei-xia commented on a diff in the pull request:

    https://github.com/apache/helix/pull/297#discussion_r250795524
  
    --- Diff: 
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java ---
    @@ -674,12 +684,24 @@ public void handleChildChange(String parentPath, 
List<String> currentChilds) {
       /**
        * Invoke the listener for the last time so that the listener could 
clean up resources
        */
    +  @Deprecated
       public void reset() {
    +    reset(true);
    +  }
    +
    +  void reset(boolean isShutdown) {
         logger.info("Resetting CallbackHandler: " + this.toString());
    --- End diff --
    
    include isShutdown here in the log?


---

Reply via email to