lei-xia commented on a change in pull request #337: Fixing
IllegalStateException for CRUSH based rebalance strategy algorithm.
URL: https://github.com/apache/helix/pull/337#discussion_r304160372
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -259,7 +259,7 @@ private boolean
computeResourceBestPossibleState(ClusterEvent event, ResourceCon
return checkBestPossibleStateCalculation(idealState);
} catch (Exception e) {
LogUtil
- .logError(logger, _eventId, "Error computing assignment for
resource " + resourceName + ". Skipping.", e);
+ .logError(logger, _eventId, "Error computing assignment for
resource " + resourceName + ". Skipping.");
// TODO : remove this part after debugging NPE
Review comment:
Can we remove this piece of code (based on the TODO comment)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
