lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance
by "touching" IdealState/ResourceConfig
URL: https://github.com/apache/helix/pull/336#discussion_r304178598
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##########
@@ -1021,11 +1021,21 @@ public static void purgeExpiredJobs(String workflow,
WorkflowConfig workflowConf
// concurrent write issue. It is possible that jobs got purged but
there is no event to
// trigger the pipeline to clean context.
HelixDataAccessor accessor = manager.getHelixDataAccessor();
- List<String> resourceConfigs =
- accessor.getChildNames(accessor.keyBuilder().resourceConfigs());
+ List<ResourceConfig> resourceConfigs =
Review comment:
Since you are getting rid of all "touches" anyway, other option is to keep
the code as it is now without changing anything. How do you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
