jiajunwang commented on a change in pull request #341: Initial checking for the Weight-Aware Globally-Even Distribute rebalancer URL: https://github.com/apache/helix/pull/341#discussion_r305213080
########## File path: helix-core/src/main/java/org/apache/helix/api/rebalancer/waged/constraints/SoftConstraint.java ########## @@ -0,0 +1,49 @@ +package org.apache.helix.api.rebalancer.waged.constraints; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import org.apache.helix.controller.rebalancer.waged.model.AssignableNode; +import org.apache.helix.controller.rebalancer.waged.model.AssignableReplica; +import org.apache.helix.controller.rebalancer.waged.model.ClusterContext; + +/** + * Evaluate a partition allocation proposal and return a score within the normalized range. + * A higher score means the proposal is more preferred. + */ +public interface SoftConstraint { + float MIN_SCORE = -1000.0f; + float MAX_SCORE = 1000.0f; Review comment: Double is not necessary. Unless we have 10K nodes to manage so that we need to differentiate the evaluated rank. Float is more efficient computing wise. (Although the difference might be minor in reality) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
