pkuwm commented on a change in pull request #339: Implementation of
stateModelDef modification in REST 2.0
URL: https://github.com/apache/helix/pull/339#discussion_r305560424
##########
File path:
helix-rest/src/test/java/org/apache/helix/rest/server/TestClusterAccessor.java
##########
@@ -405,7 +407,68 @@ public void
testEnableDisableMaintenanceModeWithCustomFields() {
accessor.getBaseDataAccessor().exists(accessor.keyBuilder().maintenance().getPath(),
0));
}
- @Test()
+ @Test(dependsOnMethods = "testEnableDisableMaintenanceModeWithCustomFields")
+ public void testGetStateModelDef() throws IOException {
+
+ System.out.println("Start test :" + TestHelper.getTestMethodName());
+ String cluster = "TestCluster_1";
+ String stateModelDefs = get("clusters/" + cluster + "/statemodeldefs",
null, Response.Status.OK.getStatusCode(), true);
+ Map<String, Object> defMap = OBJECT_MAPPER.readValue(stateModelDefs, new
TypeReference<HashMap<String, Object>>(){});
+
+ Assert.assertTrue(defMap.size()==2);
+ Assert.assertTrue(defMap.get("stateModelDefinitions") instanceof List);
+ List<String> stateModelNames =
(List<String>)defMap.get("stateModelDefinitions");
+ Assert.assertEquals(stateModelNames.size(), 6);
+
+ String oneModel = stateModelNames.get(1);
+ String twoModel = stateModelNames.get(2);
+
+ String oneModelUri = "clusters/" + cluster + "/statemodeldefs/" + oneModel;
+ String oneResult = get(oneModelUri, null,
Response.Status.OK.getStatusCode(), true);
+ ZNRecord oneRecord = OBJECT_MAPPER.readValue(oneResult, ZNRecord.class);
+
+ String twoModelUri = "clusters/" + cluster + "/statemodeldefs/" + twoModel;
+ String twoResult = get("clusters/" + cluster + "/statemodeldefs/" +
twoModel, null, Response.Status.OK.getStatusCode(), true);
Review comment:
It seems towModeUri is what you need to replace this string concatenation?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
