pkuwm commented on a change in pull request #348: Adding the configuration items of the WAGED rebalancer. URL: https://github.com/apache/helix/pull/348#discussion_r306091519
########## File path: helix-core/src/main/java/org/apache/helix/model/ClusterConfig.java ########## @@ -19,19 +19,21 @@ * under the License. */ +import com.google.common.collect.ImmutableMap; import com.google.common.collect.Maps; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashMap; -import java.util.List; -import java.util.Map; import org.apache.helix.HelixException; import org.apache.helix.HelixProperty; import org.apache.helix.ZNRecord; import org.apache.helix.api.config.HelixConfigProperty; import org.apache.helix.api.config.StateTransitionThrottleConfig; import org.apache.helix.api.config.StateTransitionTimeoutConfig; +import java.util.ArrayList; Review comment: Would it be great to put names in ASCII sort order? Update: oh, just a style format. Could define the format in the style template to make all imports consistent in the project. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
