pkuwm commented on a change in pull request #355: Changing
IllegalStateException to Helix Exception for CRUSH based rebalance strategy
algorithm.
URL: https://github.com/apache/helix/pull/355#discussion_r306147335
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
##########
@@ -257,6 +257,10 @@ private boolean
computeResourceBestPossibleState(ClusterEvent event, ResourceCon
// Check if calculation is done successfully
return checkBestPossibleStateCalculation(idealState);
+ } catch (HelixException e){
Review comment:
Does Helix Style template not handle space in this case? If not, should
improve the template.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
