alirezazamani opened a new pull request #360: Romve TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360 **Issues** The logs related to NPE in computeResourceBestPossibleState is not needed anymore and can be removed. (#351) **Description** Since this NPE condition has been thoroughly checked, these logs can be removed. **Tests** Since this PR just removes the logs, tests are not necessary. However, the mvn test results are included here: Test Result 1: (mvn test) [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestStopWorkflow.testStopTask » ThreadTimeout Method org.testng.internal.TestN... [ERROR] TestClusterVerifier.testResourceSubset:183 » ThreadTimeout Method org.testng.i... [INFO] [ERROR] Tests run: 835, Failures: 2, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:02 h [INFO] Finished at: 2019-07-23T16:21:05-07:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-core: There are test failures. [ERROR] [ERROR] Please refer to /home/anajari/my_repos/helix/helix-core/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException Test Result 2: (mvn test -Dtest="TestStopWorkflow,TestClusterVerifier") [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 59.003 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:03 min [INFO] Finished at: 2019-07-23T16:32:01-07:00 [INFO] ------------------------------------------------------------------------ **Commits** In this commit, the TODO part of BestPossibleStateCalcStage.java has been removed.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
