alirezazamani commented on a change in pull request #360: Remove TODO NPE log for computeResourceBestPossibleState URL: https://github.com/apache/helix/pull/360#discussion_r307011719
########## File path: helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java ########## @@ -263,19 +263,6 @@ private boolean computeResourceBestPossibleState(ClusterEvent event, ResourceCon } catch (Exception e) { LogUtil.logError(logger, _eventId, "Error computing assignment for resource " + resourceName + ". Skipping."); - // TODO : remove this part after debugging NPE Review comment: I updated my commit and added NPE checks. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services