jiajunwang edited a comment on issue #363: Fix the race condition while Helix 
refresh cluster status cache.
URL: https://github.com/apache/helix/pull/363#issuecomment-516107112
 
 
   @i3wangyi After tried to add the test, I found the test case that we 
discussed just tests for the specific design that was originally done. Making 
it atomic boolean basically avoid that original logic. If we are still adding 
the same test, we are testing AtomicBoolean, which is not necessary.
   
   For the integration test,  since it's a race condition, better to test in 
our long-run test environment. Otherwise, the mvn test we have now will run an 
even longer time. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to