i3wangyi opened a new issue #366: Not run in parallel and a waste of duplicate rest requests in `getParallelStoppableInstances` URL: https://github.com/apache/helix/issues/366 The implementation of the method [https://github.com/apache/helix/blob/7ac3a6a1762bc74869a8f7ea0a9c7feed8b3ba0a/helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java#L189](url) has several issues: 1. It's not actually run in parallel 2. There're potential lots of duplicate requests because the current implemetation of `InstanceServiceImpl` won't memorize the response of each query. In production, the performance will be downgraded very bad in large clusters. We need to - Parallelism the instance checks - Cache the result of http requests
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
