dasahcc commented on a change in pull request #367: Add transient cache for
CustomRestClient implementation
URL: https://github.com/apache/helix/pull/367#discussion_r309466643
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/client/CustomRestClientFactory.java
##########
@@ -28,39 +28,36 @@
import org.slf4j.LoggerFactory;
/**
- * The memory efficient factory to create instances for {@link
CustomRestClient}
+ * The memory efficient factory to getHttpClient instances for {@link
CustomRestClient}
*/
public class CustomRestClientFactory {
private static final Logger LOG =
LoggerFactory.getLogger(CustomRestClientFactory.class);
- private static CustomRestClient INSTANCE = null;
+ private static HttpClient HTTP_CLIENT_INSTANCE = null;
private CustomRestClientFactory() {
}
public static CustomRestClient get() {
Review comment:
Add some comments here to remind the CustomRestClient is per request client.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
