i3wangyi commented on a change in pull request #362: The WAGED rebalancer cluster model implementation URL: https://github.com/apache/helix/pull/362#discussion_r309978496
########## File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/AssignableReplica.java ########## @@ -19,9 +19,121 @@ * under the License. */ +import org.apache.helix.model.ResourceConfig; +import org.apache.helix.model.StateModelDefinition; + +import java.io.IOException; +import java.util.Map; + /** - * A placeholder before we have the implementation. - * * This class represents a partition replication that needs to be allocated. */ -public class AssignableReplica { } +public class AssignableReplica implements Comparable<AssignableReplica> { + private final String _partitionName; + private final String _resourceName; + private final String _resourceInstanceGroupTag; + private final int _resourceMaxPartitionsPerInstance; + private final Map<String, Integer> _capacityUsage; + // The priority of the replica's state + private final int _statePriority; + // The state of the replica + private final String _replicaState; + + /** + * @param resourceConfig The resource config for the resource which contains the replication. + * @param partitionName The replication's partition name. + * @param replicaState The state of the replication. + * @param statePriority The priority of the replication's state. + */ + AssignableReplica(ResourceConfig resourceConfig, String partitionName, String replicaState, + int statePriority) { + _partitionName = partitionName; + _replicaState = replicaState; + _statePriority = statePriority; + _resourceName = resourceConfig.getResourceName(); + _capacityUsage = fetchCapacityUsage(partitionName, resourceConfig); Review comment: If you agree on the Builder pattern, here instead of making the `fetch` method private, we could publish it in the public method of builder. Something like ``` class Builder { public Builder capacityUsage(ResourceConfig resourceConfig, String partitionName) { } } ``` It's Builder class' nature to do some heavy lifting works and public method just makes unit test so much easier. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services