narendly commented on a change in pull request #359: Dynamically change the
processor thread name when consuming event
URL: https://github.com/apache/helix/pull/359#discussion_r310147891
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
##########
@@ -1165,7 +1163,11 @@ public void run() {
+ _processorName);
while (!isInterrupted()) {
try {
- handleEvent(_eventBlockingQueue.take(), _cache);
+ ClusterEvent newClusterEvent = _eventBlockingQueue.take();
Review comment:
I don't think it's too much for the simplicity of the code, but I do think
that it will be more work for you to make that happen.
I don't know if I follow "And logically, ClusterEvent shouldn't know the
existence of threadName even queue object".
At any rate, the point still stands - it is always important to minimize the
amount of objects being created since we need to be conscious of memory
pressure. If you have other thoughts, please post them here.
I am fine with leaving this item as a **TODO** in the codebase and creating
a corresponding issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
