i3wangyi commented on a change in pull request #333: Fix issue when client only
sets ANY at cluster level throttle config
URL: https://github.com/apache/helix/pull/333#discussion_r310228147
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/stages/StateTransitionThrottleController.java
##########
@@ -99,6 +99,21 @@ public StateTransitionThrottleController(Set<String>
resources, ClusterConfig cl
}
}
+ // The getter methods are used for debugging and testing purpose
Review comment:
In addition to the subclass, you also need to make the fields protected
otherwise they won't be accessible from subclass either. Making it protected
doesn't make things better versus package-private method. Do you know why we
need to have getMethods instead of directly accessing the internal variables?
Because you could implement get methods in a more self defensive manner but
`protected` just exposes the private field
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
