Thanks Justin! Could you please help with the license part? Highly
appreciated.
Also, could you please share any docs about the Sha-1 related docs for
guidance?

Best,

Junkai

On Tue, Jun 8, 2021 at 7:56 PM Justin Mclean <jmcl...@apache.org> wrote:

> Hi,
>
> I hope you don't mind I took a look at your released and noticed a couple
> of things:
> - Sha-1 is no longer consider secure, it's best to use sha-256 or sha-512
> as a hash
> - License information should go in the LICENSE file not in NOTICE. There
> is usually no need to mention MIT or BSD license information in the NOTICE
> file. [1]
>
> If you need a hand correcting the LICENSE and NOTICE files I can help.
>
> Thanks,
> Justin
>
> 1. https://infra.apache.org/licensing-howto.html#permissive-deps
>

Reply via email to