I will add the license-maven-plugin to the pom, so that we can rely on it to update the headers while making release.
On Mon, Oct 29, 2012 at 1:49 PM, Olivier Lamy <[email protected]> wrote: > 2012/10/29 Olivier Lamy <[email protected]>: > > 2012/10/29 kishore g <[email protected]>: > >> Sure, I was not sure if rat plugin does it or you did for all files > >> manually ? My understand was rat plugin does this automatically. > > rat plugin only check :-) > > I did manually and using http://mojo.codehaus.org/license-maven-plugin/. > Manually is a mandatory as rat plugin doesn't complain Copyright > section and we have to remove it. > > > >> > >> On Mon, Oct 29, 2012 at 1:28 PM, Olivier Lamy <[email protected]> wrote: > >> > >>> so feel free to fix that :-) > >>> > >>> 2012/10/29 kishore g <[email protected]>: > >>> > There are some in non recipe folder, > >>> > > >>> > ./mockservice/src/main/java/org/apache/helix/CMConnector.java: * > >>> Copyright > >>> > (C) 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/main/java/org/apache/helix/EspressoResource.java: * > >>> > Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > > >>> > ./mockservice/src/main/java/org/apache/helix/EspressoStorageMockNode.java: > >>> > * Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > > >>> > ./mockservice/src/main/java/org/apache/helix/EspressoStorageMockStateModelFactory.java: > >>> > * Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/main/java/org/apache/helix/FnvHashFunction.java: * > >>> > Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/main/java/org/apache/helix/HashFunction.java: * > >>> Copyright > >>> > (C) 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/main/java/org/apache/helix/HashFunction.java: * > Forked > >>> > from com.linkedin.databus.core.util @ r293057 > >>> > > ./mockservice/src/main/java/org/apache/helix/MockEspressoService.java: * > >>> > Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/main/java/org/apache/helix/MockNode.java: * > Copyright > >>> (C) > >>> > 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/main/java/org/apache/helix/MockNodeFactory.java: * > >>> > Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/main/java/org/apache/helix/MockRunner.java: * > Copyright > >>> > (C) 2012 LinkedIn Inc <[email protected]> > >>> > > ./mockservice/src/main/java/org/apache/helix/StopServiceResource.java: * > >>> > Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > ./mockservice/src/test/java/org/apache/helix/AppTest.java: * > Copyright > >>> (C) > >>> > 2012 LinkedIn Inc <[email protected]> > >>> > > >>> > ./helix-core/src/main/java/org/apache/helix/examples/BootstrapProcess.java: > >>> > * Copyright (C) 2012 LinkedIn Inc <[email protected]> > >>> > > >>> > > >>> > > >>> > On Mon, Oct 29, 2012 at 1:23 PM, Olivier Lamy <[email protected]> > wrote: > >>> > > >>> >> 2012/10/29 kishore g <[email protected]>: > >>> >> > Ok that worked fine. How ever when i do this. > >>> >> > > >>> >> > grep linkedin `find . -name *.java` I see some files still have > old > >>> >> headers. > >>> >> Yup I didn't touch to recipes folders. > >>> >> > > >>> >> > > >>> >> > On Mon, Oct 29, 2012 at 1:09 PM, Olivier Lamy <[email protected]> > >>> wrote: > >>> >> > > >>> >> >> 2012/10/29 kishore g <[email protected]>: > >>> >> >> > Hi Olivier, > >>> >> >> > > >>> >> >> > Did we fix all the license headers. mvn rat:check fails with > >>> >> >> > [ERROR] Failed to execute goal > >>> >> >> > org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check > (default-cli) > >>> on > >>> >> >> > project helix: Too many unapproved licenses: 12 -> [Help 1] > >>> >> >> > > >>> >> >> > I looked at target/rat.txt and it complains about the files > under > >>> >> .git ( > >>> >> >> > Even though I see the .git to be excluded in pom.xml) > >>> >> >> > > >>> >> >> > Am i missing something? > >>> >> >> yup :-) > >>> >> >> current version of rat doesn't exclude per default .git etc.. > >>> >> >> > >>> >> >> So I move configuration to the rat profile, use: mvn clean > install > >>> >> >> -Prat (-DskipTests) > >>> >> >> > > >>> >> >> > thanks > >>> >> >> > Kishore > >>> >> >> > >>> >> >> > >>> >> >> > >>> >> >> -- > >>> >> >> Olivier Lamy > >>> >> >> Talend: http://coders.talend.com > >>> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy > >>> >> >> > >>> >> > >>> >> > >>> >> > >>> >> -- > >>> >> Olivier Lamy > >>> >> Talend: http://coders.talend.com > >>> >> http://twitter.com/olamy | http://linkedin.com/in/olamy > >>> >> > >>> > >>> > >>> > >>> -- > >>> Olivier Lamy > >>> Talend: http://coders.talend.com > >>> http://twitter.com/olamy | http://linkedin.com/in/olamy > >>> > > > > > > > > -- > > Olivier Lamy > > Talend: http://coders.talend.com > > http://twitter.com/olamy | http://linkedin.com/in/olamy > > > > -- > Olivier Lamy > Talend: http://coders.talend.com > http://twitter.com/olamy | http://linkedin.com/in/olamy >
