[
https://issues.apache.org/jira/browse/HELIX-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13619050#comment-13619050
]
Hudson commented on HELIX-75:
-----------------------------
Integrated in helix #664 (See [https://builds.apache.org/job/helix/664/])
[HELIX-75] Removing exception from throws clause of helixmanager
constructor (Revision 3f238e5a1d5531b5741be6722c52a440b3f4eb98)
[HELIX-75] removing unused import (Revision
0f4c0f1c166a6f240ce651543d253da278b73cc6)
Result = SUCCESS
g.kishore :
Files :
* helix-core/src/main/java/org/apache/helix/HelixManagerFactory.java
* helix-core/src/main/java/org/apache/helix/HelixManager.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
g.kishore :
Files :
* helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
> ZKHelixManager declares throws Exception
> ----------------------------------------
>
> Key: HELIX-75
> URL: https://issues.apache.org/jira/browse/HELIX-75
> Project: Apache Helix
> Issue Type: Bug
> Components: helix-core
> Affects Versions: 0.6.0-incubating
> Reporter: Max Calderoni
> Assignee: kishore gopalakrishna
> Priority: Minor
> Fix For: 0.6.1-incubating
>
> Attachments: helix-75.patch
>
>
> I noticed that in the signature of ZKHelixManager's constructor (and
> consequently, in HelixManagerFactory.getZKHelixManager()) there is a throws
> Exception clause.
> Two questions:
> 1. that constructor does not really throw any Exception so that throws clause
> can be removed.
> 2. even if you wanted to keep that throws clause for some reason, did you
> really mean to throw 'Exception' or something more specific than that in the
> API?
> Because that forces client code to catch runtime exceptions, which you
> normally don't really want to catch, nor want to be forced to carry along
> 'throws Exception'.
> In general, i noticed in code that there are other parts where things declare
> 'throws Exception'.
> If that is a choice for the internal code, fine, but again, if it is API,
> would be best if users were not forced by that practice.
> If all that was meant, could you please explain the arguments for this
> particular choice of throwing 'Exception'.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
