----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12955/#review23953 -----------------------------------------------------------
Ship it! Looks great. Ship it helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java <https://reviews.apache.org/r/12955/#comment47786> you can remove this constant no_node_maximum, you can set the default value of maximumpernode to integer.maxvalue helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java <https://reviews.apache.org/r/12955/#comment47787> missing check if log info is enabled. - Kishore Gopalakrishna On July 26, 2013, 12:56 a.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12955/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 12:56 a.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-141 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-141. Auto rebalancer that works for arbitrary partitions, > states, replicas, and nodes while keeping the load balanced and minimizing > movement. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/12955/diff/ > > > Testing > ------- > > Including a tester class that randomly adds, removes, and resurrects nodes > and checks summary statistics and verifies baseline correctness. It's worked > for the test cases I've tried. > > > Thanks, > > Kanak Biscuitwala > >
