----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12984/#review24005 -----------------------------------------------------------
Ship it! Have you tested for the case where N>P but number of livenodes<P and vice versa - Kishore Gopalakrishna On July 26, 2013, 11:23 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/12984/ > ----------------------------------------------------------- > > (Updated July 26, 2013, 11:23 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-148 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-148: when there are fewer partitions than nodes, then use a > different placement strategy to ensure every node has some preferred > partitions > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > 740d17d > > Diff: https://reviews.apache.org/r/12984/diff/ > > > Testing > ------- > > Ran my end-to-end test to check for regressions > > > Thanks, > > Kanak Biscuitwala > >
