----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13024/#review24154 -----------------------------------------------------------
Ship it! Ship It! helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java <https://reviews.apache.org/r/13024/#comment47980> rename to generateReplicaMap, get is confusing. Would it not be better for this to allow Replica instances in this so that we dont have to construct replica object later and get rid of using state? I might be wrong here, need to review all the places where we use state. - Kishore Gopalakrishna On July 29, 2013, 5:56 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13024/ > ----------------------------------------------------------- > > (Updated July 29, 2013, 5:56 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-150 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-150. Assigned each replica a unique identifier, removing > dependence on which state it is in. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > 740d17d > > Diff: https://reviews.apache.org/r/13024/diff/ > > > Testing > ------- > > Ran the end-to-end test against it to check correctness on bootstrap, node > creation, deletion, and resurrection. > > > Thanks, > > Kanak Biscuitwala > >
