> On July 29, 2013, 9:36 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java, > > line 629 > > <https://reviews.apache.org/r/13031/diff/1/?file=330260#file330260line629> > > > > probably a init method that passes helixmanager, total replicas, total > > partitions and number of nodes. > > > > instead of getNodeIndex rename it to getLocation that returns the > > nodename.
Probably only makes sense to init this right at the beginning and to only pass the manager. > On July 29, 2013, 9:36 p.m., Kishore Gopalakrishna wrote: > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java, > > line 626 > > <https://reviews.apache.org/r/13031/diff/1/?file=330260#file330260line626> > > > > can we get the nodenames instead of numNodes. Done. - Kanak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13031/#review24176 ----------------------------------------------------------- On July 29, 2013, 9:01 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13031/ > ----------------------------------------------------------- > > (Updated July 29, 2013, 9:01 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-149 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-149. Allow users of the auto rebalancer to pass in a custom > preferred placement scheme. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > 740d17d > > helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java > d2b44dc > > Diff: https://reviews.apache.org/r/13031/diff/ > > > Testing > ------- > > Ran the end-to-end test to make sure that the behavior was the same as before > with the default strategy. > > > Thanks, > > Kanak Biscuitwala > >
