----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13090/#review24369 -----------------------------------------------------------
Looks good to me. There's a lot of existing stray trailing spaces in the file, but that's probably best for a separate task. - Kanak Biscuitwala On July 31, 2013, 8:17 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13090/ > ----------------------------------------------------------- > > (Updated July 31, 2013, 8:17 p.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > HELIX-155: PropertyKey#instances() is wrongly wired to CONFIG type instead of > INSTANCES type: > > > public PropertyKey instances() > { > return new PropertyKey(CONFIGS, null, _clusterName); > } > > > Diffs > ----- > > helix-core/src/main/java/org/apache/helix/PropertyKey.java 80aeaf1 > > Diff: https://reviews.apache.org/r/13090/diff/ > > > Testing > ------- > > > Thanks, > > Zhen Zhang > >
