----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13081/#review24371 -----------------------------------------------------------
Ship it! Ship It! - Kishore Gopalakrishna On July 30, 2013, 9:56 p.m., Kanak Biscuitwala wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13081/ > ----------------------------------------------------------- > > (Updated July 30, 2013, 9:56 p.m.) > > > Review request for helix, Zhen Zhang, Kishore Gopalakrishna, and Shi Lu. > > > Bugs: HELIX-154 > > > Repository: helix-git > > > Description > ------- > > Fix for HELIX-154. Even though the fix for HELIX-150 removed the > consideration of state in most computations, there was some cleanup > remaining. Now, state is not even a member of the Replica class, so we can be > sure that the rebalancer does not depend on it for any computation. > > > Diffs > ----- > > > helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java > 9a998eb > > Diff: https://reviews.apache.org/r/13081/diff/ > > > Testing > ------- > > Ran the standard end-to-end auto rebalance test to make sure that the basic > correctness constraints are satisfied. > > > Thanks, > > Kanak Biscuitwala > >
