----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/13135/#review24372 -----------------------------------------------------------
Ship it! Minor comments. helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java <https://reviews.apache.org/r/13135/#comment48219> use logger helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java <https://reviews.apache.org/r/13135/#comment48220> use logger helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java <https://reviews.apache.org/r/13135/#comment48221> remove comment sysout and use logger helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java <https://reviews.apache.org/r/13135/#comment48223> ditto. move to util class in core helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java <https://reviews.apache.org/r/13135/#comment48222> move this to some utility method in main code. will this not used anywhere else ? - Kishore Gopalakrishna On July 31, 2013, 8:13 p.m., Zhen Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/13135/ > ----------------------------------------------------------- > > (Updated July 31, 2013, 8:13 p.m.) > > > Review request for helix, Kanak Biscuitwala, Kishore Gopalakrishna, and Shi > Lu. > > > Repository: helix-git > > > Description > ------- > > add 3 zk session expiry tests for new HelixManager implementation. they each > tests that: > 1) after participant zk session expiry, the number of zk wacthers and the > number of Callback handlers will not leak > 2) after controller zk session expiry, the number of zk wacthers and the > number of Callback handlers will not leak > 3) removal of zk paths will cause related Callback handlers being removed, > thus no leaking > > > Diffs > ----- > > > helix-core/src/test/java/org/apache/helix/integration/manager/ClusterControllerManager.java > PRE-CREATION > > helix-core/src/test/java/org/apache/helix/integration/manager/MockParticipantManager.java > e171539 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestAbstractManager.java > 74774d1 > > helix-core/src/test/java/org/apache/helix/integration/manager/TestZkCallbackHandlerLeak.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/13135/diff/ > > > Testing > ------- > > all tests pass locally > > > Thanks, > > Zhen Zhang > >
